binder: fix memory corruption in binder_transaction binder
authorXu YiPing <xuyiping@hisilicon.com>
Tue, 5 Sep 2017 17:21:52 +0000 (10:21 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 18 Sep 2017 14:06:00 +0000 (16:06 +0200)
commitd53bebdf4d779497b29e1aad26e19cac1d446f42
tree1cb59a7d0c0f4dc4d59536e5c75ccdc1f9f390d6
parent52b81611f209da5f49019260522633e994e241b5
binder: fix memory corruption in binder_transaction binder

commit 7a4408c6bd3e ("binder: make sure accesses to proc/thread are
safe") made a change to enqueue tcomplete to thread->todo before
enqueuing the transaction. However, in err_dead_proc_or_thread case,
the tcomplete is directly freed, without dequeued. It may cause the
thread->todo list to be corrupted.

So, dequeue it before freeing.

Fixes: 7a4408c6bd3e ("binder: make sure accesses to proc/thread are safe")
Signed-off-by: Xu YiPing <xuyiping@hisilicon.com>
Signed-off-by: Todd Kjos <tkjos@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/android/binder.c