SUNRPC: Fix failures of checksum Kunit tests
authorChuck Lever <chuck.lever@oracle.com>
Sun, 16 Apr 2023 17:05:06 +0000 (13:05 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 17 Apr 2023 13:42:54 +0000 (09:42 -0400)
commitd51425190805d47aecc1910b272e65476dd3b937
tree12cacc08bd2a5f76438588e043308c5a6895b47d
parentc8bc34660628769f71e8b230144a2a4d86ab0f91
SUNRPC: Fix failures of checksum Kunit tests

Scott reports that when the new GSS krb5 Kunit tests are built as
a separate module and loaded, the RFC 6803 and RFC 8009 checksum
tests all fail, even though they pass when run under kunit.py.

It appears that passing a buffer backed by static const memory to
gss_krb5_checksum() is a problem. A printk in checksum_case() shows
the correct plaintext, but by the time the buffer has been converted
to a scatterlist and arrives at checksummer(), it contains all
zeroes.

Replacing this buffer with one that is dynamically allocated fixes
the issue.

Reported-by: Scott Mayhew <smayhew@redhat.com>
Fixes: 02142b2ca8fc ("SUNRPC: Add checksum KUnit tests for the RFC 6803 encryption types")
Tested-by: Scott Mayhew <smayhew@redhat.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
net/sunrpc/auth_gss/gss_krb5_test.c