ALSA: aloop - add locking to timer access
authorOmair Mohammed Abdullah <omair.m.abdullah@linux.intel.com>
Sat, 29 Sep 2012 06:54:05 +0000 (12:24 +0530)
committerTakashi Iwai <tiwai@suse.de>
Sat, 6 Oct 2012 14:50:28 +0000 (16:50 +0200)
commitd4f1e48bd11e3df6a26811f7a1f06c4225d92f7d
tree9095cf6f07b86a43df416c7ebdd261967935053d
parentd17344b3547669f5b6ee4fda993d03737a141bd6
ALSA: aloop - add locking to timer access

When the loopback timer handler is running, calling del_timer() (for STOP
trigger) will not wait for the handler to complete before deactivating the
timer. The timer gets rescheduled in the handler as usual. Then a subsequent
START trigger will try to start the timer using add_timer() with a timer pending
leading to a kernel panic.

Serialize the calls to add_timer() and del_timer() using a spin lock to avoid
this.

Signed-off-by: Omair Mohammed Abdullah <omair.m.abdullah@linux.intel.com>
Signed-off-by: Vinod Koul <vinod.koul@linux.intel.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/drivers/aloop.c