EDAC/i5100: Fix error handling order in i5100_init_one()
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Wed, 26 Aug 2020 12:14:37 +0000 (20:14 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 08:05:32 +0000 (09:05 +0100)
commitd463e4b902cb468bc49c6068397dfd53cb7b8cf1
tree2d5f49f785e8b6629a4ae0910dffa1ab605d9ca4
parentf46af0e0896b23e896d0e80e510120bcb9e53ef6
EDAC/i5100: Fix error handling order in i5100_init_one()

[ Upstream commit 857a3139bd8be4f702c030c8ca06f3fd69c1741a ]

When pci_get_device_func() fails, the driver doesn't need to execute
pci_dev_put(). mci should still be freed, though, to prevent a memory
leak. When pci_enable_device() fails, the error injection PCI device
"einj" doesn't need to be disabled either.

 [ bp: Massage commit message, rename label to "bail_mc_free". ]

Fixes: 52608ba205461 ("i5100_edac: probe for device 19 function 0")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20200826121437.31606-1-dinghao.liu@zju.edu.cn
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/edac/i5100_edac.c