xfs: reserve enough blocks to handle btree splits when remapping
authorDarrick J. Wong <darrick.wong@oracle.com>
Wed, 12 Apr 2017 19:26:07 +0000 (12:26 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 7 Jun 2017 10:07:52 +0000 (12:07 +0200)
commitd457f822817f9ab3a28b89b090dee5e4c5fb7ddf
tree441d9d8e5eaab27c3b93a889eef9aca3537cd8bf
parent0ba833fe73d246b0bfb76403b7b67a890cf87b5e
xfs: reserve enough blocks to handle btree splits when remapping

commit fe0be23e68200573de027de9b8cc2b27e7fce35e upstream.

In xfs_reflink_end_cow, we erroneously reserve only enough blocks to
handle adding 1 extent.  This is problematic if we fragment free space,
have to do CoW, and then have to perform multiple bmap btree expansions.
Furthermore, the BUI recovery routine doesn't reserve /any/ blocks to
handle btree splits, so log recovery fails after our first error causes
the filesystem to go down.

Therefore, refactor the transaction block reservation macros until we
have a macro that works for our deferred (re)mapping activities, and fix
both problems by using that macro.

With 1k blocks we can hit this fairly often in g/187 if the scratch fs
is big enough.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/xfs/libxfs/xfs_trans_space.h
fs/xfs/xfs_bmap_item.c
fs/xfs/xfs_reflink.c