RDMA/mlx5: Check pcie_relaxed_ordering_enabled() in UMR
authorAvihai Horon <avihaih@nvidia.com>
Mon, 10 Apr 2023 13:07:51 +0000 (16:07 +0300)
committerLeon Romanovsky <leon@kernel.org>
Sun, 16 Apr 2023 10:29:14 +0000 (13:29 +0300)
commitd43b020b0f82c088ef8ff3196ef00575a97d200e
tree724b067341fff9c465593757d10f877242ae2062
parented4b0661cce119870edb1994fd06c9cbc1dc05c3
RDMA/mlx5: Check pcie_relaxed_ordering_enabled() in UMR

relaxed_ordering_read HCA capability is set if both the device supports
relaxed ordering (RO) read and RO is set in PCI config space.

RO in PCI config space can change during runtime. This will change the
value of relaxed_ordering_read HCA capability in FW, but the driver will
not see it since it queries the capabilities only once.

This can lead to the following scenario:
1. RO in PCI config space is enabled.
2. User creates MKey without RO.
3. RO in PCI config space is disabled.
   As a result, relaxed_ordering_read HCA capability is turned off in FW
   but remains on in driver copy of the capabilities.
4. User requests to reconfig the MKey with RO via UMR.
5. Driver will try to reconfig the MKey with RO read although it
   shouldn't (as relaxed_ordering_read HCA capability is really off).

To fix this, check pcie_relaxed_ordering_enabled() before setting RO
read in UMR.

Fixes: 896ec9735336 ("RDMA/mlx5: Set mkey relaxed ordering by UMR with ConnectX-7")
Signed-off-by: Avihai Horon <avihaih@nvidia.com>
Reviewed-by: Shay Drory <shayd@nvidia.com>
Link: https://lore.kernel.org/r/8d39eb8317e7bed1a354311a20ae707788fd94ed.1681131553.git.leon@kernel.org
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
drivers/infiniband/hw/mlx5/umr.c