faceoverlay: fix weird pad creation code
authorTim-Philipp Müller <tim.muller@collabora.co.uk>
Thu, 15 Mar 2012 16:52:44 +0000 (16:52 +0000)
committerTim-Philipp Müller <tim.muller@collabora.co.uk>
Thu, 15 Mar 2012 16:52:44 +0000 (16:52 +0000)
commitd405ea2e632363e560dd3784177f249196bb2bc1
treed9f5154a98915aa56a6dbfc13ebf4748a68d4163
parentfead44ad128ddbb054d108ce9489233a04069d65
faceoverlay: fix weird pad creation code

The element would create normal pads in its instance_init function,
and then later in NULL->READY create the elements it needs, remove
the pads created in the instance_init function, and add new ghost
pads instead. Not without saving the external peer pads of the old
pads of course, which it would promptly re-link to the new ghost
pads. Do all of that a bit differently.

Fixes the generic/states.check unit test.

https://bugzilla.gnome.org/show_bug.cgi?id=670588
gst/faceoverlay/gstfaceoverlay.c
gst/faceoverlay/gstfaceoverlay.h