selftests: fib_tests: sleep after changing carrier. again.
authorThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Fri, 22 Feb 2019 10:27:41 +0000 (07:27 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 23 Mar 2019 19:09:52 +0000 (20:09 +0100)
commitd3f62d3eab0beff6877c2035d6a6f556f8d921a0
tree1b1a047d7ed94750b43e4ab0112dfb7a277ef557
parent8cd89bf632b2903591fae34b5f0cf11dbf28638b
selftests: fib_tests: sleep after changing carrier. again.

[ Upstream commit af548a27b158d548d41e56255e6eaca1658cc3be ]

Just like commit e2ba732a1681 ("selftests: fib_tests: sleep after
changing carrier"), wait one second to allow linkwatch to propagate the
carrier change to the stack.

There are two sets of carrier tests. The first slept after the carrier
was set to off, and when the second set ran, it was likely that the
linkwatch would be able to run again without much delay, reducing the
likelihood of a race. However, if you run 'fib_tests.sh -t carrier' on a
loop, you will quickly notice the failures.

Sleeping on the second set of tests make the failures go away.

Cc: David Ahern <dsahern@gmail.com>
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/testing/selftests/net/fib_tests.sh