Call QObject::disconnectNotify() when receiver is destroyed
authorKent Hansen <kent.hansen@nokia.com>
Mon, 25 Jun 2012 18:19:11 +0000 (20:19 +0200)
committerQt by Nokia <qt-info@nokia.com>
Thu, 28 Jun 2012 12:44:20 +0000 (14:44 +0200)
commitd359b0af2b93aeb9c22714be1cec881417650ed8
treeedc793d9197500d094c5ee9a01ba3ce252b36c5a
parent26c85a5f79875a25367527462e8d0864021078ab
Call QObject::disconnectNotify() when receiver is destroyed

Store the signal index in QObjectPrivate::Connection, thereby making
it available in "implicit" disconnect contexts (i.e., receiver
deletion).

This change does not cause the size of QObjectPrivate::Connection
to grow (still 40 bytes on 32-bit Linux, 72 bytes on 64-bit Mac).

Valgrinding the new benchmark indicates that the percentage of the
time spent in the QObject destructor increased from 7.8% to 8.4%
on ia32, for that particular stress test; the increase is the
combined cost of calling metaObject(), QMetaObjectPrivate::signal(),
and disconnectNotify() for one connection. In practice, the measured
wallclock time increased by about 3ms for a 500ms run (which
repeatedly constructs, connects, and destroys an object).

Task-number: QTBUG-4844

Change-Id: I1beb01c753f31542fc0acb62edb4c6d165fcc5b4
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
src/corelib/kernel/qobject.cpp
src/corelib/kernel/qobject_p.h
tests/auto/corelib/kernel/qobject/tst_qobject.cpp
tests/benchmarks/corelib/kernel/qobject/main.cpp