drm: fix mutex leak in drm_dp_get_mst_branch_device
authorAdam Richter <adamrichter4@gmail.com>
Fri, 16 Oct 2015 10:33:02 +0000 (03:33 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 Nov 2015 22:33:33 +0000 (14:33 -0800)
commitd347b289bf2767fe6d2c87589c38cc194a6a07c5
treef62a41f7e180951cb08a4a57f1c3d7ff994ede64
parent29589707855ec7ed432a614ee91e3fab38643233
drm: fix mutex leak in drm_dp_get_mst_branch_device

commit 30730c7f5943b3beace1e29f7f1476e05de3da14 upstream.

In Linux 4.3-rc5, there is an error case in drm_dp_get_branch_device
that returns without releasing mgr->lock, resulting a spew of kernel
messages about a kernel work function possibly having leaked a mutex
and presumably more serious adverse consequences later.  This patch
changes the error to "goto out" to unlock the mutex before returning.

[airlied: grabbed from drm-next as it fixes something we've seen]

Signed-off-by: Adam J. Richter <adam_richter2004@yahoo.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/drm_dp_mst_topology.c