nvme: fix discard support without oncs
authorKeith Busch <kbusch@kernel.org>
Mon, 3 Apr 2023 20:09:25 +0000 (13:09 -0700)
committerChristoph Hellwig <hch@lst.de>
Wed, 5 Apr 2023 15:13:17 +0000 (17:13 +0200)
commitd3205ab75e99a47539ec91ef85ba488f4ddfeaa9
tree0ce464a0960034f2dc2af9f919de73ab35bba857
parent38a8c4d1d45006841f0643f4cb29b5e50758837c
nvme: fix discard support without oncs

The device can report discard support without setting the ONCS DSM bit.
When not set, the driver clears max_discard_size expecting it to be set
later. We don't know the size until we have the namespace format,
though, so setting it is deferred until configuring one, but the driver
was abandoning the discard settings due to that initial clearing.

Move the max_discard_size calculation above the check for a '0' discard
size.

Fixes: 1a86924e4f46475 ("nvme: fix interpretation of DMRSL")
Reported-by: Laurence Oberman <loberman@redhat.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Tested-by: Laurence Oberman <loberman@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/core.c