ALSA: control: Make sure that id->index does not overflow
authorLars-Peter Clausen <lars@metafoo.de>
Wed, 18 Jun 2014 11:32:35 +0000 (13:32 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 26 Jun 2014 19:15:43 +0000 (15:15 -0400)
commitd30b5ce4b5da77451fad1f454f3d456f8d3040cf
tree164a4d6008b7fbcd5ebd4425816863048f37a66e
parent8e1853b436edc41ee4e0214cf5a2fc04201915f8
ALSA: control: Make sure that id->index does not overflow

commit 883a1d49f0d77d30012f114b2e19fc141beb3e8e upstream.

The ALSA control code expects that the range of assigned indices to a control is
continuous and does not overflow. Currently there are no checks to enforce this.
If a control with a overflowing index range is created that control becomes
effectively inaccessible and unremovable since snd_ctl_find_id() will not be
able to find it. This patch adds a check that makes sure that controls with a
overflowing index range can not be created.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/core/control.c