Do not call QWidget::show/hideEvent twice
authorOliver Wolff <oliver.wolff@digia.com>
Wed, 17 Oct 2012 13:50:01 +0000 (15:50 +0200)
committerThe Qt Project <gerrit-noreply@qt-project.org>
Thu, 8 Nov 2012 14:01:52 +0000 (15:01 +0100)
commitd2e5c7787e82fe3157ca3100a0e465a0ed7c5685
tree5adb0ff24e55e0487be836299e1131d6dcc96396
parenta6f49a4223dcfdfb92889d26323783342e50d9a2
Do not call QWidget::show/hideEvent twice

While handling events for Widgets and Windows in QWidgetWindow::event
makes sense for other events, it causes QWidget::show/hideEvent to be
called twice when handled like "the rest". Having that as one case here
seems to be the cleanest solution. Removing the call to showEvent from
QWidgetPrivate::show_helper (as proposed in the bug report) causes
autotests to fail and thus is not a viable option.

Additionally the expected result for the task221221 test for
QDoubleSpinBox was reverted to the Qt4 value as Qt4 behaviour was
restored.

Task-number: QTBUG-27199
Task-number: QTBUG-26424
Task-number: QTBUG-22565

Change-Id: I0ac42b09b1a7618de042d27aa5dd1b3d9f30f552
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: Andy Shaw <andy.shaw@digia.com>
src/widgets/kernel/qwidgetwindow.cpp
tests/auto/widgets/kernel/qwidget/tst_qwidget.cpp
tests/auto/widgets/widgets/qdoublespinbox/tst_qdoublespinbox.cpp
tests/auto/widgets/widgets/qmenu/tst_qmenu.cpp