[clang][deps] Remove unintentional `move`
authorJan Svoboda <jan_svoboda@apple.com>
Tue, 18 Oct 2022 03:04:33 +0000 (20:04 -0700)
committerJan Svoboda <jan_svoboda@apple.com>
Tue, 18 Oct 2022 23:40:31 +0000 (16:40 -0700)
commitd239f3c627a396a80181806960957d5d0eba7e91
tree7c9866e6ea21efa7783755a8bf51b959e7b19486
parent5f154795efc999cb0b6c15e82bbdf55ec15d1cac
[clang][deps] Remove unintentional `move`

This is a fix related to D135414. The original intention was to keep `BaseFS` as a member of the worker and conditionally overlay it with local in-memory FS. The `move` of ref-counted `BaseFS` was not intended, and it's a bug.

Disabling parallelism in the "by-module-name" test reliably reproduces this, and the test itself doesn't *need* parallelism. (I think `-j 4` was cargo culted from another test.) Reusing that test to check for correct behavior...

Reviewed By: DavidSpickett

Differential Revision: https://reviews.llvm.org/D136124
clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp
clang/test/ClangScanDeps/modules-full-by-mod-name.cpp