media: hantro: fix post-processing NULL pointer dereference
authorJonas Karlman <jonas@kwiboo.se>
Sun, 12 Jan 2020 13:34:24 +0000 (14:34 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 23 Jan 2020 12:09:24 +0000 (13:09 +0100)
commitd239aa00fe7bb40175822da4b4300c140877fe06
tree2fc43f682ab37f9e8b696f9123ef58da7365f2b2
parent1fd4d9cb739bd47b74840f8933616cc75341db05
media: hantro: fix post-processing NULL pointer dereference

The RK3399 variant does not have postproc_regs declared,
this can cause a NULL pointer dereference trying to decode:

[   89.331359] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000

[   89.352804] Call trace:
[   89.353191]  hantro_postproc_disable+0x20/0xe8 [hantro_vpu]
[   89.354056]  hantro_start_prepare_run+0x58/0x68 [hantro_vpu]
[   89.354923]  hantro_h264_dec_prepare_run+0x30/0x6f0 [hantro_vpu]
[   89.355846]  rk3399_vpu_h264_dec_run+0x1c/0x14a8 [hantro_vpu]
[   89.356748]  device_run+0xa4/0xb8 [hantro_vpu]

Fix this by adding a NULL check in hantro_postproc_enable/disable.

Fixes: 8c2d66b036c7 ("media: hantro: Support color conversion via post-processing")
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/hantro/hantro_postproc.c