ksmbd: fix reference count leak in smb_check_perm_dacl()
authorXin Xiong <xiongx18@fudan.edu.cn>
Fri, 29 Apr 2022 08:11:22 +0000 (16:11 +0800)
committerSteve French <stfrench@microsoft.com>
Tue, 10 May 2022 03:23:01 +0000 (22:23 -0500)
commitd21a580dafc69aa04f46e6099616146a536b0724
tree37a8d47748781bd72b83192bb3dbfc11372ec4e6
parentc5eb0a61238dd6faf37f58c9ce61c9980aaffd7a
ksmbd: fix reference count leak in smb_check_perm_dacl()

The issue happens in a specific path in smb_check_perm_dacl(). When
"id" and "uid" have the same value, the function simply jumps out of
the loop without decrementing the reference count of the object
"posix_acls", which is increased by get_acl() earlier. This may
result in memory leaks.

Fix it by decreasing the reference count of "posix_acls" before
jumping to label "check_access_bits".

Fixes: 777cad1604d6 ("ksmbd: remove select FS_POSIX_ACL in Kconfig")
Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/ksmbd/smbacl.c