Removed most of the bogus CompilationInfo constructor calls.
authorsvenpanne <svenpanne@chromium.org>
Wed, 11 Feb 2015 14:12:03 +0000 (06:12 -0800)
committerCommit bot <commit-bot@chromium.org>
Wed, 11 Feb 2015 14:12:15 +0000 (14:12 +0000)
commitd1b5aa0716752e328102fb7b0780d750c08a3673
treec1338cee6c1b59f186e153a1636214035ad8a4bf
parent505b6020a86378df98df4356d4ae8db182ef9dda
Removed most of the bogus CompilationInfo constructor calls.

A CompilationInfo constructed from just an Isolate* and a Zone* is in
weird an inconsistent state (calling e.g. flags() on it will crash),
so we need to avoid them. This CL removes almost all of them, the
remaining 2 call sites in (for testing only) will be handled in a
separate CL. Things which have been changed:

  * Linkage is basically a decorator for CallDescriptor now.

  * ChangeLowering doesn't need Linkage at all.

  * JSGenericLowering doesn't need a full CompilationInfo*, just a
    single flag.

  * JSContextSpecializer doesn't need the full CompilationInfo, just a
    Context.

  * Removed unused CompilationInfo from SimplifiedLoweringTester.

This nicely decouples things already a bit more, but there's still
work to do...

Review URL: https://codereview.chromium.org/899803003

Cr-Commit-Position: refs/heads/master@{#26580}
16 files changed:
src/compiler/change-lowering.cc
src/compiler/change-lowering.h
src/compiler/js-context-specialization.cc
src/compiler/js-context-specialization.h
src/compiler/js-generic-lowering.cc
src/compiler/js-generic-lowering.h
src/compiler/linkage.cc
src/compiler/linkage.h
src/compiler/pipeline.cc
test/cctest/compiler/test-changes-lowering.cc
test/cctest/compiler/test-instruction.cc
test/cctest/compiler/test-js-context-specialization.cc
test/cctest/compiler/test-linkage.cc
test/cctest/compiler/test-simplified-lowering.cc
test/unittests/compiler/change-lowering-unittest.cc
test/unittests/compiler/instruction-selector-unittest.cc