power: supply: ltc2941-battery-gauge: fix use-after-free
authorSven Van Asbroeck <thesven73@gmail.com>
Thu, 19 Sep 2019 15:11:37 +0000 (11:11 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Feb 2020 12:34:02 +0000 (04:34 -0800)
commitd12fbc55c1e9d293cdb73695377b7cd6421ca7d6
treef21b97a3e2120fd97efb0b88c6c4d32ce6dfc122
parenta6b40467ea75bc374f6c4a3e202bbb3dbb1ae651
power: supply: ltc2941-battery-gauge: fix use-after-free

commit a60ec78d306c6548d4adbc7918b587a723c555cc upstream.

This driver's remove path calls cancel_delayed_work().
However, that function does not wait until the work function
finishes. This could mean that the work function is still
running after the driver's remove function has finished,
which would result in a use-after-free.

Fix by calling cancel_delayed_work_sync(), which ensures that
that the work is properly cancelled, no longer running, and
unable to re-schedule itself.

This issue was detected with the help of Coccinelle.

Cc: stable <stable@vger.kernel.org>
Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/power/supply/ltc2941-battery-gauge.c