net/mlx5e: shut up maybe-uninitialized warning
authorArnd Bergmann <arnd@arndb.de>
Fri, 30 Sep 2016 16:17:09 +0000 (18:17 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 3 Oct 2016 05:55:18 +0000 (01:55 -0400)
commitd0debb76df18f05ecc65579d37203703ffdec44d
tree1038925afe772b9d61ce81fd3aaeccf71c265d7f
parent7c70c4f8b2bf5ed777120f3d70efe35e64930c10
net/mlx5e: shut up maybe-uninitialized warning

Build-testing this driver with -Wmaybe-uninitialized gives a new false-positive
warning that I can't really explain:

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c: In function 'mlx5e_configure_flower':
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:509:3: error: 'old_attr' may be used uninitialized in this function [-Werror=maybe-uninitialized]

It's obvious from the code that 'old_attr' is initialized whenever 'old'
is non-NULL here. The warning appears with all versions I tested from gcc-4.7
through gcc-6.1, and I could not come up with a way to rewrite the function
in a more readable way that avoids the warning, so I'm adding another
initialization to shut it up.

Fixes: 8b32580df1cb ("net/mlx5e: Add TC vlan action for SRIOV offloads")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c