pinctrl: sh-pfc: add missing of_node_put
authorJulia Lawall <Julia.Lawall@lip6.fr>
Mon, 21 Dec 2015 16:39:46 +0000 (17:39 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 22 Dec 2015 12:45:53 +0000 (13:45 +0100)
commitd0b3ed4160201930b505ed9dedc4f80780ad4ff1
tree9c24d7717d8d3422f628abb11d70ac648468d4af
parent2d98023c16048dc59aa54514b4b52da61aa66b13
pinctrl: sh-pfc: add missing of_node_put

for_each_child_of_node performs an of_node_get on each iteration, so a
goto out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
local idexpression n;
expression e,e1;
identifier l;
@@

 for_each_child_of_node(e1,n) {
   ...
(
   of_node_put(n);
|
   e = n
|
   return n;
|
+  of_node_put(n);
?  goto l;
)
   ...
 }
l: ... when != n
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/sh-pfc/pinctrl.c