cpufreq: powernv: Fix use-after-free
authorOliver O'Halloran <oohall@gmail.com>
Thu, 6 Feb 2020 06:26:21 +0000 (17:26 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 13 Mar 2020 10:13:11 +0000 (21:13 +1100)
commitd0a72efac89d1c35ac55197895201b7b94c5e6ef
tree7ccd069c42df06af64cb6dd79d772ed3fd1f7fcf
parentffd3eaf178b0f616a071e510e289d937330b0b35
cpufreq: powernv: Fix use-after-free

The cpufreq driver has a use-after-free that we can hit if:

a) There's an OCC message pending when the notifier is registered, and
b) The cpufreq driver fails to register with the core.

When a) occurs the notifier schedules a workqueue item to handle the
message. The backing work_struct is located on chips[].throttle and
when b) happens we clean up by freeing the array. Once we get to
the (now free) queued item and the kernel crashes.

Fixes: c5e29ea7ac14 ("cpufreq: powernv: Fix bugs in powernv_cpufreq_{init/exit}")
Cc: stable@vger.kernel.org # v4.6+
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Reviewed-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200206062622.28235-1-oohall@gmail.com
drivers/cpufreq/powernv-cpufreq.c