aco: rework lower_to_cssa()
authorDaniel Schürmann <daniel@schuermann.dev>
Mon, 13 Jan 2020 16:35:11 +0000 (17:35 +0100)
committerDaniel Schürmann <daniel@schuermann.dev>
Thu, 16 Jan 2020 15:01:59 +0000 (16:01 +0100)
commitd098024c40ee6bd12804833b71a554380df2d51d
treedb4e49f8fb18d1852365d7c30b331cf056861e48
parent300f8dec76f846f2c49bafd3bd3d76b7ffc0923b
aco: rework lower_to_cssa()

This patch changes lower_to_cssa to be much more conservative
about assumptions which phi operands might interfere.
Previously, this pass wasn't exhaustive and could miss some corner cases.

v2: remove optimizations to find better insertion points as it's hard
to guarantee that they are always correct and have overall no benefit.

Fixes: 0b8216b2cdbcaccfd2bd1a65be6b8ac5654e3067 ('aco: Lower to CSSA')

Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3385>
src/amd/compiler/aco_lower_to_cssa.cpp