rtnelink: Move link dump consistency check out of the loop
authorJakub Sitnicki <jkbs@redhat.com>
Wed, 9 Aug 2017 15:39:12 +0000 (17:39 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 Aug 2017 02:43:57 +0000 (19:43 -0700)
commitd0225784be6c9bdfb05149ebc30bf9fc1fdbce3a
tree644e179df77456c4721f2be1b537926ebdc9a038
parentaa69ff9e9c32db8aa84835baffea1b70c39e5112
rtnelink: Move link dump consistency check out of the loop

Calls to rtnl_dump_ifinfo() are protected by RTNL lock. So are the
{list,unlist}_netdevice() calls where we bump the net->dev_base_seq
number.

For this reason net->dev_base_seq can't change under out feet while
we're looping over links in rtnl_dump_ifinfo(). So move the check for
net->dev_base_seq change (since the last time we were called) out of the
loop.

This way we avoid giving a wrong impression that there are concurrent
updates to the link list going on while we're iterating over them.

Signed-off-by: Jakub Sitnicki <jkbs@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/rtnetlink.c