ice: fix stack leakage
authorJesse Brandeburg <jesse.brandeburg@intel.com>
Fri, 8 Nov 2019 14:23:21 +0000 (06:23 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 26 Jan 2020 09:01:01 +0000 (10:01 +0100)
commitd0198ab3a28fc7b0ae8199f44e151af9ddf09ee2
tree711f502a197fd1b70b9fee9fa47a613a46d0ff67
parent2bc814d98e92f94b03ce51aa588491935d46c642
ice: fix stack leakage

commit 949375de945f7042df2b6488228a1a2b36e69f35 upstream.

In the case of an invalid virtchannel request the driver
would return uninitialized data to the VF from the PF stack
which is a bug.  Fix by initializing the stack variable
earlier in the function before any return paths can be taken.

Fixes: 1071a8358a28 ("ice: Implement virtchnl commands for AVF support")
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/intel/ice/ice_virtchnl_pf.c