drm: avoid uninitialized timestamp use in wait_vblank
authorArnd Bergmann <arnd@arndb.de>
Mon, 17 Oct 2016 22:13:39 +0000 (00:13 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 18 Oct 2016 07:45:17 +0000 (09:45 +0200)
commitcff52e5fc4cfc978b7df898dc14a0492c7ef0ae8
treefd16fb42a9d3e98483b65b14d6f127d47d1a66c0
parent9edbf1fa600a2ef17c7553c2103d0055d0320d15
drm: avoid uninitialized timestamp use in wait_vblank

gcc warns about the timestamp in drm_wait_vblank being possibly
used without an initialization:

drivers/gpu/drm/drm_irq.c: In function 'drm_crtc_send_vblank_event':
drivers/gpu/drm/drm_irq.c:992:24: error: 'now.tv_usec' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/gpu/drm/drm_irq.c:1069:17: note: 'now.tv_usec' was declared here
drivers/gpu/drm/drm_irq.c:991:23: error: 'now.tv_sec' may be used uninitialized in this function [-Werror=maybe-uninitialized]

This can happen if drm_vblank_count_and_time() returns 0 in its
error path. To sanitize the error case, I'm changing that function
to return a zero timestamp when it fails.

Fixes: e6ae8687a87b ("drm: idiot-proof vblank")
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
Cc: Rob Clark <robdclark@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Mario Kleiner <mario.kleiner.de@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20161017221355.1861551-6-arnd@arndb.de
drivers/gpu/drm/drm_irq.c