[cmake] Strip quotes in compiler-rt/lib/crt; error if checks fail
authorGeorge Burgess IV <george.burgess.iv@gmail.com>
Mon, 9 Mar 2020 22:48:19 +0000 (15:48 -0700)
committerGeorge Burgess IV <george.burgess.iv@gmail.com>
Mon, 9 Mar 2020 22:52:39 +0000 (15:52 -0700)
commitcfc3e7f458f8798782c01a0dadf872c60340c23e
tree85967cb66ac55a8f509648ade8db982cc4dc3ca0
parent20dfcf189d224e637377970318a021c81d2fbde0
[cmake] Strip quotes in compiler-rt/lib/crt; error if checks fail

Patch by Zhizhou Yang!

In his own words:

"""
Similar change to CMakeLists as r372312.

After r372209, compiler command line may include argument with quotes:

```
-fprofile-instr-use="/foo/bar.profdata"
```

And it causes a hidden failure with execute_process later: Could not
read profile "/foo/bar.profdata": No such file or directory.

In this particular case, the check for .init_array will fail silently
and creates a PGO-ed binary with bad .init_array section in compiler-rt.

Bug details can be found in PR45022
"""

Differential Revision: https://reviews.llvm.org/D75065
compiler-rt/lib/crt/CMakeLists.txt