[CodeGenPrepare] Fix isIVIncrement (PR49466)
authorTa-Wei Tu <tu.da.wei@gmail.com>
Tue, 9 Mar 2021 05:31:20 +0000 (13:31 +0800)
committerTa-Wei Tu <tu.da.wei@gmail.com>
Tue, 9 Mar 2021 05:32:34 +0000 (13:32 +0800)
commitcf82700af8c658ae09b14c3d01bb1e73e48d3bd3
treedc72048bcc021c3099320585bff6013d0de3648c
parent038f2a337d09e114469ddcfba5b613cdb8c0fe1d
[CodeGenPrepare] Fix isIVIncrement (PR49466)

In the NFC commit 8d835f42a57f15c0b9053bd7c41ea95821a40e5f, the check for `!L` is
moved to a separate function `getIVIncrement` which, instead of using `BO->getParent()`,
uses `PN->getParent()`. However, these two basic blocks are not necessarily the same.

https://bugs.llvm.org/show_bug.cgi?id=49466 demonstrates a case where `PN` is contained in
a loop while `BO` is not, causing the null-pointer dereference in `L->getLoopLatch()`.

This patch checks whether both `BO` and `PN` belong to the same loop before entering `getIVIncrement`.

Reviewed By: mkazantsev

Differential Revision: https://reviews.llvm.org/D98144
llvm/lib/CodeGen/CodeGenPrepare.cpp
llvm/test/CodeGen/X86/pr49466.ll [new file with mode: 0644]