9p: remove dead stores (variable set again without being read)
authorDominique Martinet <asmadeus@codewreck.org>
Wed, 3 May 2023 07:49:29 +0000 (16:49 +0900)
committerEric Van Hensbergen <ericvh@kernel.org>
Thu, 20 Jul 2023 19:14:50 +0000 (19:14 +0000)
commitcf7c33d332ab67603f159123b691c61270b14c33
treefd142d7ab528cde06448bbeaa6a95abf4b88a0b0
parentf41b402d2572e93bee85669ed05eb5e1f3725704
9p: remove dead stores (variable set again without being read)

The 9p code for some reason used to initialize variables outside of the
declaration, e.g. instead of just initializing the variable like this:

int retval = 0

We would be doing this:

int retval;
retval = 0;

This is perfectly fine and the compiler will just optimize dead stores
anyway, but scan-build seems to think this is a problem and there are
many of these warnings making the output of scan-build full of such
warnings:
fs/9p/vfs_inode.c:916:2: warning: Value stored to 'retval' is never read [deadcode.DeadStores]
        retval = 0;
        ^        ~

I have no strong opinion here, but if we want to regularly run
scan-build we should fix these just to silence the messages.

I've confirmed these all are indeed ok to remove.

Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
Signed-off-by: Eric Van Hensbergen <ericvh@kernel.org>
fs/9p/vfs_inode.c
fs/9p/vfs_inode_dotl.c
net/9p/client.c