regmap: Split regmap_get_endian() in two functions
authorGeert Uytterhoeven <geert+renesas@glider.be>
Wed, 27 Aug 2014 14:36:03 +0000 (16:36 +0200)
committerMark Brown <broonie@linaro.org>
Wed, 27 Aug 2014 16:45:56 +0000 (17:45 +0100)
commitcf673fbc6342b1c2310cdfdc4ed99f18f866b8e4
tree49954b4cd132431f9c3c3d6e0ced4c1e0cf7d3c7
parent45e1a279ce1d2ff9b2b2fedf4cdced10c7ca3ab5
regmap: Split regmap_get_endian() in two functions

Split regmap_get_endian() in two functions, regmap_get_reg_endian() and
regmap_get_val_endian().

This allows to:
  - Get rid of the three switch()es on "type", incl. error handling in
    three "default" cases,
  - Get rid of the regmap_endian_type enum,
  - Get rid of the non-NULL check of "config" (regmap_init() already
    checks for that),
  - Get rid of the "endian" output parameters, and just return the
    regmap_endian enum value, as the functions can no longer fail.

This saves 21 lines of code (despite the still-present
one-comment-per-line over-documentation), and 30 bytes of code on ARM
V7.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/base/regmap/regmap.c