KVM: x86/pmu: Avoid using PEBS perf_events for normal counters
authorLike Xu <likexu@tencent.com>
Wed, 31 Aug 2022 08:53:24 +0000 (16:53 +0800)
committerSean Christopherson <seanjc@google.com>
Wed, 28 Sep 2022 19:47:22 +0000 (12:47 -0700)
commitcf52de619c67bd1f6b1cf2751c3827815f74a5a5
tree6732b9f1731b7e3eb20b8b6f7280ca9d70098651
parentc0245b774203f7341ddb1cce29a6ee607857f325
KVM: x86/pmu: Avoid using PEBS perf_events for normal counters

The check logic in the pmc_resume_counter() to determine whether
a perf_event is reusable is partial and flawed, especially when it
comes to a pseudocode sequence (contrived, but valid) like:

  - enabling a counter and its PEBS bit
  - enable global_ctrl
  - run workload
  - disable only the PEBS bit, leaving the global_ctrl bit enabled

In this corner case, a perf_event created for PEBS can be reused by
a normal counter before it has been released and recreated, and when this
normal counter overflows, it triggers a PEBS interrupt (precise_ip != 0).

To address this issue, reprogram all affected counters when PEBS_ENABLE
change and reuse a counter if and only if PEBS exactly matches precise.

Fixes: 79f3e3b58386 ("KVM: x86/pmu: Reprogram PEBS event to emulate guest PEBS counter")
Signed-off-by: Like Xu <likexu@tencent.com>
Link: https://lore.kernel.org/r/20220831085328.45489-4-likexu@tencent.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
arch/x86/kvm/pmu.c
arch/x86/kvm/vmx/pmu_intel.c