drm/i915: Also drop vm.ref along error paths for vma construction
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 2 Jul 2020 21:10:15 +0000 (22:10 +0100)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Tue, 7 Jul 2020 00:16:03 +0000 (17:16 -0700)
commitcf1976b11372cac3b57fbae1831f66a4486355d3
tree30b404fc5782ea6b674007e19372b5173c2d56fd
parent42723673a193d5f8e30dba6ea9826d42262a502b
drm/i915: Also drop vm.ref along error paths for vma construction

Not only do we need to release the vm.ref we acquired for the vma on the
duplicate insert branch, but also for the normal error paths, so roll
them all into one.

Reported-by: Andi Shyti <andi.shyti@intel.com>
Suggested-by: Andi Shyti <andi.shyti@intel.com>
Fixes: 2850748ef876 ("drm/i915: Pull i915_vma_pin under the vm->mutex")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Andi Shyti <andi.shyti@intel.com>
Cc: <stable@vger.kernel.org> # v5.5+
Reviewed-by: Andi Shyti <andi.shyti@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200702211015.29604-1-chris@chris-wilson.co.uk
(cherry picked from commit 03fca66b7a36b52da8915341eee388267f6d5b73)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/i915_vma.c