fdc: Reject unimplemented error actions
authorMarkus Armbruster <armbru@redhat.com>
Thu, 27 May 2010 18:06:12 +0000 (20:06 +0200)
committerKevin Wolf <kwolf@redhat.com>
Tue, 6 Jul 2010 15:05:49 +0000 (17:05 +0200)
commitceeae418fe97e285994bbe5a749f393699a3eb11
tree82637de6701c3a0d1b76d8e178aaa048f79479f2
parent227440cf6c215da01d10de5d8f3f2d5ac954eeb0
fdc: Reject unimplemented error actions

drive_init() doesn't permit them for if=floppy, but that's worthless:
we get them via if=none and -global.

This can make device initialization fail.  Since all callers of
fdctrl_init_isa() ignore its value, change it to die instead of
returning failure.  Without this, some callers would ignore the
failure, and others would crash.

Wart: unlike drive_init(), we don't reject the default action when
it's explicitly specified.  That's because we can't distinguish "no
rerror option" from "rerror=report", or "no werror" from
"rerror=enospc".  Left for another day.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
hw/fdc.c