Fix treatment of symbol versions with unused as-needed libraries.
authorCary Coutant <ccoutant@gmail.com>
Thu, 21 Jun 2018 20:51:16 +0000 (13:51 -0700)
committerCary Coutant <ccoutant@gmail.com>
Thu, 21 Jun 2018 20:54:16 +0000 (13:54 -0700)
commitcea6ffbd06a6ebb5c21cb51e7775b8ebb5e34f38
treea051cfe643463bc74fd4c9cdd75db0d0c9137a53
parent1ced1a5f108fd0a0c88d2298dbdd2dd2a2ee38f0
Fix treatment of symbol versions with unused as-needed libraries.

When we have a weak reference to a symbol defined in an
as-needed library, and that library ends up not-needed, gold
simply clears the version information in the symbol table, even
if the symbol could have been resolved by a needed library later
in the link order. This results in a loss of version information,
which can cause the program to bind to the wrong version at run
time.

This patch lets a dynamic definition override an earlier one if
the earlier one is from a not-needed library, so that we can
retain the version information from the binding to the needed
library. In order to do that, the tracking of needed/not-needed
had to be moved up to symbol resolution time, instead of during
Symbol_table::set_dynsym_indexes().

In cases where we still end up discarding version information,
I've added a warning.

For the original problem report and discussion, see:

https://stackoverflow.com/questions/50751421/undefined-behavior-in-shared-lib-using-libpthread-but-not-having-it-in-elf-as-d

gold/
* resolve.cc (Symbol_table::resolve): Rename tobinding to
orig_tobinding.  Call set_is_needed() for objects that resolve
non-weak references.
(Symbol_table::should_override): Allow a dynamic definition to
override an earlier one in a not-needed library.
* symtab.cc (Symbol_table::set_dynsym_indexes): Remove separate
processing for as-needed symbols.  Add warning when discarding
version informatin.
* testsuite/Makefile.am (weak_as_needed): New test case.
* testsuite/Makefile.in: Regenerate.
* testsuite/weak_as_needed.sh: New test script.
* testsuite/weak_as_needed_a.c: New source file.
* testsuite/weak_as_needed_b.c: New source file.
* testsuite/weak_as_needed_b.script: New version script.
* testsuite/weak_as_needed_c.c: New source file.
* testsuite/weak_as_needed_c.script: New version script.
gold/ChangeLog
gold/resolve.cc
gold/symtab.cc
gold/testsuite/Makefile.am
gold/testsuite/Makefile.in
gold/testsuite/weak_as_needed.sh [new file with mode: 0755]
gold/testsuite/weak_as_needed_a.c [new file with mode: 0644]
gold/testsuite/weak_as_needed_b.c [new file with mode: 0644]
gold/testsuite/weak_as_needed_b.script [new file with mode: 0644]
gold/testsuite/weak_as_needed_c.c [new file with mode: 0644]
gold/testsuite/weak_as_needed_c.script [new file with mode: 0644]