Document SHA1 buffer requirements more clearly
authorDavid Woodhouse <David.Woodhouse@intel.com>
Thu, 14 Jun 2012 07:34:11 +0000 (08:34 +0100)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Thu, 14 Jun 2012 07:41:45 +0000 (08:41 +0100)
commitce8df71d2a7b31d7a7a4e74cd2adbbb5989c93f2
tree7e1317ce5e63ea0c21ea522f4b8ab1591ca1cbe7
parent4cbb1ce4ebe19a362573128fbe6b9057ad9e80db
Document SHA1 buffer requirements more clearly

There's an inconsistency here; openconnect_set_xmlsha1() takes a redundant
'len' arg which serves no purpose except to check that the caller knows
how big a SHA1 is. If it's not 41, we bail.

Next time the soname is getting bumped, I'll add a similar redundant
check to openconnect_get_cert_sha1() too. I should have done that when
it was first converted from an internal function to a public-facing one
in commit 20840ab0. But I didn't, and it's not worth bumping the soname
again right now *just* for that.

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
openconnect.h