Fix Image layout transitions for diff_attachments_*

Fix Image layout transitions for diff_attachments_*

Fix an incorrect image layout transition before
using images as COLOR ATTACHMENT in a render pass
for the dEQP-VK.pipeline.framebuffer_attachment.diff_attachments_*
tests.
After the clear operation, the test under question,
should have transitioned the images to
COLOR_ATTACHMENT_OPTIMAL with ACCESS_COLOR_ATTACHMENT_WRITE.
Instead, the layout was incorrectly transitioned to
VK_ACCESS_COLOR_ATTACHMENT_READ_BIT / VK_IMAGE_LAYOUT_GENERAL.

Affects:
dEQP-VK.pipeline.framebuffer_attachment.diff_attachments_*

Components: Vulkan

VK-GL-CTS issue: 2545

Change-Id: I815b1cf459b033f02871eebff5b71cb1a45b9d1c