md/raid5: schedule_construction should abort if nothing to do.
authorNeilBrown <neilb@suse.de>
Mon, 4 Mar 2013 01:37:14 +0000 (12:37 +1100)
committerNeilBrown <neilb@suse.de>
Wed, 20 Mar 2013 01:16:51 +0000 (12:16 +1100)
commitce7d363aaf1e28be8406a2976220944ca487e8ca
tree2f098d1ddf1165fffc3d9ae74c91684b78bb1072
parentf3378b48705154b9089affb2d2e939622aea68f1
md/raid5: schedule_construction should abort if nothing to do.

Since commit 1ed850f356a0a422013846b5291acff08815008b
    md/raid5: make sure to_read and to_write never go negative.

It has been possible for handle_stripe_dirtying to be called
when there isn't actually any work to do.
It then calls schedule_reconstruction() which will set R5_LOCKED
on the parity block(s) even when nothing else is happening.
This then causes problems in do_release_stripe().

So add checks to schedule_reconstruction() so that if it doesn't
find anything to do, it just aborts.

This bug was introduced in v3.7, so the patch is suitable
for -stable kernels since then.

Cc: stable@vger.kernel.org (v3.7+)
Reported-by: majianpeng <majianpeng@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/raid5.c