target/iscsi: avoid NULL dereference in CHAP auth error path
authorDavid Disseldorp <ddiss@suse.de>
Wed, 13 Dec 2017 17:22:30 +0000 (18:22 +0100)
committerNicholas Bellinger <nab@linux-iscsi.org>
Fri, 12 Jan 2018 23:07:27 +0000 (15:07 -0800)
commitce512d79d0466a604793addb6b769d12ee326822
treea6863b9b2a3eacd3635d197762f0727846bb2ae0
parent093ec1430f41063d65dfc68d7eddec9d80f8efbb
target/iscsi: avoid NULL dereference in CHAP auth error path

If chap_server_compute_md5() fails early, e.g. via CHAP_N mismatch, then
crypto_free_shash() is called with a NULL pointer which gets
dereferenced in crypto_shash_tfm().

Fixes: 69110e3cedbb ("iscsi-target: Use shash and ahash")
Suggested-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David Disseldorp <ddiss@suse.de>
Cc: stable@vger.kernel.org # 4.6+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/iscsi/iscsi_target_auth.c