drm/rockchip: cdn-dp: fix sign extension on an int multiply for a u64 result
authorColin Ian King <colin.king@canonical.com>
Tue, 15 Sep 2020 16:20:49 +0000 (17:20 +0100)
committerHeiko Stuebner <heiko@sntech.de>
Fri, 28 May 2021 18:27:44 +0000 (20:27 +0200)
commitce0cb93a5adb283f577cd4661f511047b5e39028
tree9c9f907905d7619ce37e2d15a70bf96692561452
parent3dfa159f6b0c054eb63673fbf643a5f2cc862e63
drm/rockchip: cdn-dp: fix sign extension on an int multiply for a u64 result

The variable bit_per_pix is a u8 and is promoted in the multiplication
to an int type and then sign extended to a u64. If the result of the
int multiplication is greater than 0x7fffffff then the upper 32 bits will
be set to 1 as a result of the sign extension. Avoid this by casting
tu_size_reg to u64 to avoid sign extension and also a potential overflow.

Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20200915162049.36434-1-colin.king@canonical.com
drivers/gpu/drm/rockchip/cdn-dp-reg.c