regulator: Fix regression due to NULL constraints check
authorTakashi Iwai <tiwai@suse.de>
Tue, 3 Mar 2015 13:28:51 +0000 (14:28 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 4 Mar 2015 12:31:01 +0000 (12:31 +0000)
commitcde72ccfdd5920abb0413d16240c1551de3bd13a
tree5300ae2245998992e08ff0f3006c2299151b6247
parentc517d838eb7d07bbe9507871fab3931deccff539
regulator: Fix regression due to NULL constraints check

The commit [39f802d6b6d9: 'regulator: Build sysfs entries with static
attribute groups'] converted the sysfs entry creation to static
attribute groups, but this resulted in a regression due to the NULL
check of rdev->constraints.  At the point where the device is
registered, rdev->constraints isn't set, so the attributes depending
on it are missing.

We may fix it by shuffling the code order in regulator_register(), but
a quicker fix is to just remove this NULL check.  rdev->constraints is
in anyway always set to non-NULL in set_machine_constraints(), thus
the check there is basically superfluous.

Fixes: 39f802d6b6d9 ('regulator: Build sysfs entries with static attribute groups')
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Reportded-by: Steve Twiss <stwiss.opensource@diasemi.com>
Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/core.c