memory: samsung: exynos5422-dmc: Fix refcount leak in of_get_dram_timings
authorMiaoqian Lin <linmq006@gmail.com>
Thu, 2 Jun 2022 04:17:21 +0000 (08:17 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jun 2022 07:03:31 +0000 (09:03 +0200)
commitcde4480b5ab06195b9164184b0c02ced71e601b4
tree9a5ae598dc24a1eb122780d464073d178719d548
parent4d9c60e868f7cf8e09956e7d5bb44d807d712699
memory: samsung: exynos5422-dmc: Fix refcount leak in of_get_dram_timings

commit 1332661e09304b7b8e84e5edc11811ba08d12abe upstream.

of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
This function doesn't call of_node_put() in some error paths.
To unify the structure, Add put_node label and goto it on errors.

Fixes: 6e7674c3c6df ("memory: Add DMC driver for Exynos5422")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Link: https://lore.kernel.org/r/20220602041721.64348-1-linmq006@gmail.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/memory/samsung/exynos5422-dmc.c