irqchip/mbigen: Unify the error handling in mbigen_of_create_domain()
authorKefeng Wang <wangkefeng.wang@huawei.com>
Fri, 5 May 2023 09:06:54 +0000 (17:06 +0800)
committerMarc Zyngier <maz@kernel.org>
Tue, 16 May 2023 10:19:29 +0000 (11:19 +0100)
commitcddb536a73ef2c82ce04059dc61c65e85a355561
treec0034e1f852e9b1741e181029d18ab568c8dc744
parent14130211be5366a91ec07c3284c183b75d8fba17
irqchip/mbigen: Unify the error handling in mbigen_of_create_domain()

Dan Carpenter reported that commit fea087fc291b "irqchip/mbigen: move
to use bus_get_dev_root()" leads to the following Smatch static checker
warning:

drivers/irqchip/irq-mbigen.c:258 mbigen_of_create_domain()
error: potentially dereferencing uninitialized 'child'.

It should not cause a problem on real hardware, but better to fix the
warning, let's move the bus_get_dev_root() out of the loop, and unify
the error handling to silence it.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20230505090654.12793-1-wangkefeng.wang@huawei.com
drivers/irqchip/irq-mbigen.c