[TableGen] Allow 2^63-1 and 2^63-2 as int literals.
authorSimon Tatham <simon.tatham@arm.com>
Tue, 12 Mar 2019 09:28:19 +0000 (09:28 +0000)
committerSimon Tatham <simon.tatham@arm.com>
Tue, 12 Mar 2019 09:28:19 +0000 (09:28 +0000)
commitcdb7c31f0adaa9fb338ec1a226cfd44cd9d31c5d
treeb6ea6777eb8c892319f12063872cd482da365607
parentc965d21f3318cbe9f7140ca33fda4dfb8b5212bb
[TableGen] Allow 2^63-1 and 2^63-2 as int literals.

These two values correspond to the 'Empty' and 'Tombstone' special
keys defined by DenseMapInfo<int64_t>, which means that neither one
can be used as a key in DenseMap<int64_t, anything>. Hence, if you try
to use either of those values as an int literal, IntInit::get() fails
an assertion when it tries to insert them into its static cache of
int-literal objects.

Fixed by replacing the DenseMap with a std::map, which doesn't intrude
on the space of legal values of the key type.

Reviewers: nhaehnle, hfinkel, javedabsar, efriedma

Reviewed By: efriedma

Subscribers: fhahn, efriedma, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D59016

llvm-svn: 355900
llvm/lib/TableGen/Record.cpp
llvm/test/TableGen/IntSpecialValues.td [new file with mode: 0644]