ext3,ext4: don't mess with dir_file->f_pos in htree_dirblock_to_tree()
authorAl Viro <viro@ZenIV.linux.org.uk>
Mon, 1 Jul 2013 12:12:38 +0000 (08:12 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 22 Jul 2013 01:19:00 +0000 (18:19 -0700)
commitcd9c898c13afe7577790a32d29109386342045fe
tree883c1808c6ce30819fbca475f773b866c5f2e6fa
parent3cba6eb1c7cd51176b972ae47736d8e7a0720706
ext3,ext4: don't mess with dir_file->f_pos in htree_dirblock_to_tree()

commit 64cb927371cd2ec43758d8a094a003d27bc3d0dc upstream.

Both ext3 and ext4 htree_dirblock_to_tree() is just filling the
in-core rbtree for use by call_filldir().  All updates of ->f_pos are
done by the latter; bumping it here (on error) is obviously wrong - we
might very well have it nowhere near the block we'd found an error in.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext3/namei.c
fs/ext4/namei.c