projects / platform / kernel / linux-starfive.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 2da6877) | patch
rtc: r7301: Fix a possible sleep-in-atomic bug in rtc7301_read_time
authorJia-Ju Bai <baijiaju1990@gmail.com>
Wed, 13 Dec 2017 13:55:50 +0000 (21:55 +0800)
committerAlexandre Belloni <alexandre.belloni@free-electrons.com>
Thu, 11 Jan 2018 23:20:28 +0000 (00:20 +0100)
commitcd8c0bb2bd57c48c451ebea86065257ef2500b00
tree4eb179a50caab10d3ababa0a7f3b6358ae74a8f7tree | snapshot
parent2da6877f0e2ced7825a31556ada6b2ac2e50877fcommit | diff
rtc: r7301: Fix a possible sleep-in-atomic bug in rtc7301_read_time

The driver may sleep under a spinlock.
The function call path is:
rtc7301_read_time (acquire the spinlock)
  rtc7301_wait_while_busy
    usleep_range --> may sleep

To fix it, usleep_range is replaced with udelay.

This bug is found by my static analysis tool(DSAC) and checked by my code review.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
drivers/rtc/rtc-r7301.c diff | blob | history
Domain: System / Kernel;