review.tizen.org Git - platform/upstream/dotnet/runtime.git/commit

projects / platform / upstream / dotnet / runtime.git / commit

author	Stephen Toub <stoub@microsoft.com>
	Mon, 5 Aug 2019 15:05:14 +0000 (11:05 -0400)
committer	GitHub <noreply@github.com>
	Mon, 5 Aug 2019 15:05:14 +0000 (11:05 -0400)
commit	cd386d1dbbc33fef4d77550b0e0c1d3c40524816
tree	9c8512365c23c79bbe19af09dba084380a2e0d1a	tree \| snapshot
parent	ec7bce1ae964e3c61126de0263e043a263bb4100	commit \| diff

Remove some unused locals (dotnet/corefx#39956)

* Remove some unused locals

Trying out various analyzers, including one to flag unused locals. There are more than this, but this is a first batch. Some of these are just clean-up. Others are saving unnecessary cost. At least one appears to be a real functional bug.

* Address PR feedback

Commit migrated from https://github.com/dotnet/corefx/commit/545d9959aebded62a26d20c7c1bf86785a92e52a

69 files changed:

src/libraries/Common/src/System/Data/ProviderBase/DbConnectionInternal.cs		diff \| blob \| history
src/libraries/Common/src/System/Net/CaseInsensitiveAscii.cs		diff \| blob \| history
src/libraries/Common/src/System/Net/WebSockets/ManagedWebSocket.cs		diff \| blob \| history
src/libraries/Common/src/System/Reflection/Emit/IgnoreAccessChecksToAttributeBuilder.cs		diff \| blob \| history
src/libraries/Microsoft.CSharp/src/Microsoft/CSharp/RuntimeBinder/Semantics/ExpressionBinder.cs		diff \| blob \| history
src/libraries/System.Collections.Immutable/src/System/Collections/Immutable/ImmutableArray_1.Minimal.cs		diff \| blob \| history
src/libraries/System.Collections/src/System/Collections/Generic/SortedSet.cs		diff \| blob \| history
src/libraries/System.ComponentModel.Composition.Registration/src/System/ComponentModel/Composition/Registration/RegistrationBuilder.cs		diff \| blob \| history
src/libraries/System.ComponentModel.Composition/src/System/ComponentModel/Composition/ReflectionModel/GenericServices.cs		diff \| blob \| history
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs		diff \| blob \| history
src/libraries/System.Composition.Convention/src/System/Composition/Convention/ConventionBuilder.cs		diff \| blob \| history
src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ClientConfigurationHost.cs		diff \| blob \| history
src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/Configuration.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Data/Common/DbDataAdapter.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Data/DataRelation.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Data/DataSet.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Data/DataTable.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Data/DataView.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Data/Filter/ExpressionParser.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Data/Filter/FunctionNode.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Data/SQLTypes/SQLDecimal.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Data/Select.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Data/Selection.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Data/XDRSchema.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Data/XMLDiffLoader.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Data/XmlDataLoader.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Xml/XPathNodePointer.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Xml/XmlBoundElement.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Xml/XmlDataDocument.cs		diff \| blob \| history
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcDataReader.cs		diff \| blob \| history
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcHandle.cs		diff \| blob \| history
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/LocalDBAPI.Common.cs		diff \| blob \| history
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlCommand.cs		diff \| blob \| history
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlConnection.cs		diff \| blob \| history
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlDependency.cs		diff \| blob \| history
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/SqlDependencyListener.cs		diff \| blob \| history
src/libraries/System.Data.SqlClient/src/System/Data/SqlClient/TdsParser.cs		diff \| blob \| history
src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/DiagnosticSourceEventSource.cs		diff \| blob \| history
src/libraries/System.Diagnostics.EventLog/src/System/Diagnostics/EventLogInternal.cs		diff \| blob \| history
src/libraries/System.Diagnostics.PerformanceCounter/src/System/Diagnostics/PerformanceCounterLib.cs		diff \| blob \| history
src/libraries/System.Diagnostics.PerformanceCounter/src/System/Diagnostics/PerformanceData/CounterSetInstance.cs		diff \| blob \| history
src/libraries/System.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/ldap/LdapPartialResultsProcessor.cs		diff \| blob \| history
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/Domain.cs		diff \| blob \| history
src/libraries/System.IO.Compression.Brotli/src/System/IO/Compression/dec/BrotliStream.Decompress.cs		diff \| blob \| history
src/libraries/System.Net.Http.WinHttpHandler/src/System/Net/Http/WinHttpResponseParser.cs		diff \| blob \| history
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/ConnectHelper.cs		diff \| blob \| history
src/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs		diff \| blob \| history
src/libraries/System.Net.HttpListener/src/System/Net/Windows/WebSockets/WebSocketBase.cs		diff \| blob \| history
src/libraries/System.Net.Sockets/src/System/Net/Sockets/Socket.Tasks.cs		diff \| blob \| history
src/libraries/System.Net.Sockets/src/System/Net/Sockets/SocketAsyncEventArgs.Windows.cs		diff \| blob \| history
src/libraries/System.Net.WebClient/src/System/Net/WebClient.cs		diff \| blob \| history
src/libraries/System.Private.DataContractSerialization/src/System/Runtime/Serialization/Json/ReflectionJsonFormatReader.cs		diff \| blob \| history
src/libraries/System.Private.DataContractSerialization/src/System/Runtime/Serialization/Json/ReflectionJsonFormatWriter.cs		diff \| blob \| history
src/libraries/System.Private.DataContractSerialization/src/System/Runtime/Serialization/ReflectionReader.cs		diff \| blob \| history
src/libraries/System.Private.DataContractSerialization/src/System/Runtime/Serialization/ReflectionXmlFormatWriter.cs		diff \| blob \| history
src/libraries/System.Reflection.Context/src/System/Reflection/Context/Custom/CustomType.cs		diff \| blob \| history
src/libraries/System.Reflection.Metadata/src/System/Reflection/PortableExecutable/DebugDirectory/DebugDirectoryBuilder.cs		diff \| blob \| history
src/libraries/System.Reflection.MetadataLoadContext/src/System/Reflection/TypeLoading/CustomAttributes/RoPseudoCustomAttributeData.cs		diff \| blob \| history
src/libraries/System.Reflection.MetadataLoadContext/src/System/Reflection/TypeLoading/Types/Ecma/EcmaGenericTypeParameterType.cs		diff \| blob \| history
src/libraries/System.Reflection.MetadataLoadContext/src/System/Reflection/TypeLoading/Types/RoArrayType.cs		diff \| blob \| history
src/libraries/System.Runtime.Numerics/src/System/Numerics/BigNumber.cs		diff \| blob \| history
src/libraries/System.Security.Cryptography.Algorithms/src/System/Security/Cryptography/AesCcm.Unix.cs		diff \| blob \| history
src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/KeyInfoRetrievalMethod.cs		diff \| blob \| history
src/libraries/System.Security.Principal.Windows/src/System/Security/Principal/WindowsIdentity.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Reader/Utf8JsonReader.MultiSegment.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.cs		diff \| blob \| history
src/libraries/System.Text.RegularExpressions/src/System/Text/RegularExpressions/RegexCompiler.cs		diff \| blob \| history
src/libraries/System.Threading.Channels/src/System/Threading/Channels/BoundedChannel.cs		diff \| blob \| history
src/libraries/System.Threading/src/System/Threading/Barrier.cs		diff \| blob \| history

Domain: Dotnet / Core;

RSS Atom