Rename all QWindow properties that have "window" in them
authorShawn Rutledge <shawn.rutledge@digia.com>
Mon, 22 Oct 2012 10:47:34 +0000 (12:47 +0200)
committerThe Qt Project <gerrit-noreply@qt-project.org>
Wed, 7 Nov 2012 20:26:08 +0000 (21:26 +0100)
commitcd34da54269e6cd7fa5c18242d982736f022a14a
tree841d021b924f04dfcb7068fdbd9a428b9ce78c2f
parenta454ccb89ec2296234ee7328095f27ad7cb2361f
Rename all QWindow properties that have "window" in them

windowTitle, windowModality, windowIcon and so on are named that way
to be similar to the ones in QWidget.  However QQuickWindow inherits
all of the declared properties, and we would like to have shorter
property names in QML.  If you are working with a Window then it's
obvious the title property is the window title.  Unfortunately,
there must be patches in many other modules which depend on this one.
In order to avoid the need to merge them all at the same time,
there is also patch https://codereview.qt-project.org/#change,39001
which temporarily adds backwards-compatible accessors, which can be
removed after the other modules are able to build without them.

We should not rename windowState to state, because in QML, state
usually drives the state machine for animation transitions etc.
(although QWindow is not an Item, a user might get confused about it).

Related patches are
https://codereview.qt-project.org/#change,39001
https://codereview.qt-project.org/#change,37764
https://codereview.qt-project.org/#change,37765
https://codereview.qt-project.org/#change,37766
https://codereview.qt-project.org/#change,37762

Change-Id: Ie4424ec15fbdef6b29b137f90a2ae33f173edd21
Reviewed-by: Samuel Rødal <samuel.rodal@digia.com>
26 files changed:
examples/gui/analogclock/main.cpp
examples/opengl/hellowindow/hellowindow.cpp
examples/opengl/hellowindow/main.cpp
examples/opengl/paintedwindow/paintedwindow.cpp
examples/qpa/windows/main.cpp
examples/qpa/windows/window.cpp
src/gui/accessible/qaccessibleobject.cpp
src/gui/kernel/qguiapplication.cpp
src/gui/kernel/qwindow.cpp
src/gui/kernel/qwindow.h
src/platformsupport/dnd/qshapedpixmapdndwindow.cpp
src/plugins/platforms/cocoa/qcocoamenubar.mm
src/plugins/platforms/cocoa/qcocoawindow.mm
src/plugins/platforms/windows/qwindowsbackingstore.cpp
src/plugins/platforms/windows/qwindowscontext.cpp
src/plugins/platforms/windows/qwindowsintegration.cpp
src/plugins/platforms/windows/qwindowskeymapper.cpp
src/plugins/platforms/windows/qwindowswindow.cpp
src/plugins/platforms/xcb/qxcbdrag.cpp
src/plugins/platforms/xcb/qxcbwindow.cpp
src/widgets/kernel/qapplication.cpp
src/widgets/kernel/qwidget_qpa.cpp
tests/auto/gui/kernel/qguiapplication/tst_qguiapplication.cpp
tests/auto/gui/kernel/qinputmethod/tst_qinputmethod.cpp
tests/auto/gui/kernel/qwindow/tst_qwindow.cpp
tests/auto/other/qaccessibility/tst_qaccessibility.cpp