media: cx25840: don't open-code cx25840_reset() inside cx25840_load_fw()
authorMaciej S. Szmigiero <mail@maciej.szmigiero.name>
Mon, 29 Apr 2019 16:16:52 +0000 (12:16 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 28 May 2019 19:29:53 +0000 (15:29 -0400)
commitccf7a31f1ed96ee211f660c488d49a85f586417c
treed8e5cbfe2cb53a51575c4bb244b191ff3cbf0b6d
parent39cb46751e2fbb72e0698f80e339db1fd4e1f50e
media: cx25840: don't open-code cx25840_reset() inside cx25840_load_fw()

cx25840_load_fw() does the same thing as cx25840_reset(), only keeps
"is_initialized" flag so any further invocation of this function besides
the first one is a NOP.
Let's just call cx25840_reset() directly from cx25840_load_fw() instead of
open coding it there.

While we are at it, let's also improve comments about cx25840_load_fw()
so they are current and in the proper style (one of them even referred to a
non-existing cx25840 init operation).

Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/i2c/cx25840/cx25840-core.c
include/media/drv-intf/cx25840.h