[lldb][NFC] Don't let Process inherit from UserID
authorRaphael Isemann <teemperor@gmail.com>
Wed, 18 Nov 2020 13:30:06 +0000 (14:30 +0100)
committerRaphael Isemann <teemperor@gmail.com>
Wed, 18 Nov 2020 13:33:48 +0000 (14:33 +0100)
commitccd9091d4a2fd55cb455e61fa77530e1a5de6e69
tree7b3cbf0136b6557916f090a40321ab4aaf4142a9
parentda2e4728c71f9f8569246fb881c21811f8182c75
[lldb][NFC] Don't let Process inherit from UserID

I noticed that Process is inheriting from UserID to store its PID value. This patch
replaces this with a dedicated field in the Process class. This is NFC, but has some
small effects on the code using Process:
* `GetID()` now returns a `lldb::pid_t` like all other process code instead of `lldb::user_id_t`. Both are typedefs for `uint64_t`, so no change in behaviour.
* The equality operators defined for UserID no longer accept Process instances.
* Removes the inherited method `Process::Clear()` which didn't actually clear anything beside the PID value.

We maybe should also remove the getters/setters to `S/GetPID` or something like that. I can update all the code for that
in a follow-up NFC commit.

Reviewed By: labath

Differential Revision: https://reviews.llvm.org/D91699
lldb/include/lldb/Target/Process.h
lldb/source/Target/Process.cpp