[llvm-objdump] Call exit(1) on error, i.e. fail early.
authorDavide Italiano <davide@freebsd.org>
Wed, 5 Aug 2015 07:18:31 +0000 (07:18 +0000)
committerDavide Italiano <davide@freebsd.org>
Wed, 5 Aug 2015 07:18:31 +0000 (07:18 +0000)
commitccd53feee28e1da37a40a25f1638fd0af595f0dc
treeedf486f8dfac285866d7c23eb1afce8f73e1b1b7
parent650d7f7dd50d0941da22b33aedfb5c4ab9573b34
[llvm-objdump] Call exit(1) on error, i.e. fail early.

Previously we kept going on partly corrupted input, which might result
in garbage being printed, or even worse, random crashes.
Rafael mentioned that this is the GNU behavior as well, but after some
discussion we both agreed it's probably better to emit a reasonable
error message and exit. As a side-effect of this commit, now we don't
rely on global state for error codes anymore. objdump was the last tool
in the toolchain which needed to be converted. Hopefully the old behavior
won't sneak into the tree again.

llvm-svn: 244019
llvm/tools/llvm-objdump/COFFDump.cpp
llvm/tools/llvm-objdump/MachODump.cpp
llvm/tools/llvm-objdump/llvm-objdump.cpp
llvm/tools/llvm-objdump/llvm-objdump.h