drm/msm: Remove redundant check for 'submit'
authorAashish Sharma <shraash@google.com>
Tue, 11 Oct 2022 07:55:19 +0000 (13:25 +0530)
committerRob Clark <robdclark@chromium.org>
Fri, 14 Oct 2022 16:33:12 +0000 (09:33 -0700)
commitccc40d42bd59ac858b58322775004613f1d805af
treef8384636f2b4ac06ad1b6011c33bdc2f8786fef6
parentec4fbd791519423726ce9fd5130de9a95365c8eb
drm/msm: Remove redundant check for 'submit'

Rectify the below smatch warning:
drivers/gpu/drm/msm/msm_gem_submit.c:963 msm_ioctl_gem_submit() warn:
variable dereferenced before check 'submit'

'submit' is normally error pointer or valid, so remove its NULL
initializer as it's confusing and also remove a redundant check for it's
value.

Signed-off-by: Aashish Sharma <shraash@google.com>
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Patchwork: https://patchwork.freedesktop.org/patch/506653/
Link: https://lore.kernel.org/r/20221011075519.3111928-1-shraash@google.com
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/msm_gem_submit.c